uninstall.sh: prevent deleting none related homebrew files

[pheiduck]

I uninstalled homebrew because of a problem.
Uninstaller prompted me to delete: /usr/local/MacGPG2/ which isn't a Homebrew related file so skip it to be shown on none deleted directories and files by the script.

[SMillerDev]

I don't think we want to add special handling for tools that install in the homebrew prefix. Especially since it's the legacy prefix. But I'll leave this open for the opinions of others.

[pheiduck]

Thanks, let me explain it a bit more the folder is from the GPG Suite
After the deletation from the directory the tool was broken.

[maxim-belkin]

I don't think we want to add special handling for tools...

I agree

... that install in the homebrew prefix.

Homebrew doesn't own /usr/local.

I uninstalled homebrew because of a problem.
Uninstaller prompted me to delete: /usr/local/MacGPG2/

@pheiduck: do you happen to have any logs? Without logs it's hard to tell what the issue is: why Homebrew prompted you to remove files in /usr/local instead of /opt/homebrew, what Homebrew version you had, ...?

I too have GPG Suite installed, but Homebrew uninstaller doesn't prompt me to remove it:

Screenshot

[pheiduck]

I don't think we want to add special handling for tools...

I agree

... that install in the homebrew prefix.

Homebrew doesn't own /usr/local.

I uninstalled homebrew because of a problem.
Uninstaller prompted me to delete: /usr/local/MacGPG2/

@pheiduck: do you happen to have any logs? Without logs it's hard to tell what the issue is: why Homebrew prompted you to remove files in /usr/local instead of /opt/homebrew, what Homebrew version you had, ...?

I too have GPG Suite installed, but Homebrew uninstaller doesn't prompt me to remove it:
Screenshot

$ uname -m                                                                                                                                           
x86_64
$ brew --version                                                                                                                                      
Homebrew 4.4.13-51-gaeed9ef
$ brew --prefix                                                                                                                                       
/usr/local

$ /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/uninstall.sh)"
Warning: This script will remove:
/Users/pheiduck/Library/Caches/Homebrew/
/Users/pheiduck/Library/Logs/Homebrew/
/usr/local/Caskroom/
/usr/local/Cellar/
/usr/local/bin/brew -> /usr/local/bin/brew
Are you sure you want to uninstall Homebrew? This will remove your installed packages! [y/N]

[pheiduck]

I talk about this step:
https://github.com/Homebrew/install/blob/6a7c192718e25ecf154a34493c0af824661ccad0/uninstall.sh#L474C1-L474C65

[maxim-belkin]

Ok, so you've got x86_64 Mac and that's the reason your prefix is /usr/local. Can you find the flaw in script's logic that causes the uninstall.sh script to mark MacGPG2 files for deletion? As @SMillerDev pointed out - we shouldn't be calling out any specific tools in the script.

[pheiduck]

It happen in this Part of the Script:

dir_children "${HOMEBREW_REPOSITORY}" "${HOMEBREW_PREFIX}" |
  sort -u >"${tmpdir}/residual_files"

if [[ -s "${tmpdir}/residual_files" && -z "${opt_quiet}" ]]
then
  echo "The following possible Homebrew files were not deleted:"
  while read -r f
  do
    pretty_print_pathnames "${f}"
  done <"${tmpdir}/residual_files"
  echo -e "You may wish to remove them yourself.\n"
fi

[pheiduck]

add an one liner like: grep -v "MacGPG2" "${tmpdir}/residual_files" > "${tmpdir}/filtered_residual_files" could also help

[gromgit]

add an one liner like: grep -v "MacGPG2" "${tmpdir}/residual_files" > "${tmpdir}/filtered_residual_files" could also help

Sorry, excluding just one of the potentially infinite number of possible directories that can be created by other software under /usr/local is the worst possible way to fix this.

@Homebrew/maintainers, thinking out loud: should uninstall.sh even look at /usr/local for residual files, since it's a known dumping ground for most open-source projects?

[carlocab]

🤷 The current wording of

The following possible Homebrew files were not deleted:

and

You may wish to remove them yourself.

seems fine to me.

[pheiduck]

okay, I close it now.

[maxim-belkin]

@Homebrew/maintainers, thinking out loud: should uninstall.sh even look at /usr/local for residual files, since it's a known dumping ground for most open-source projects?

I don't think it should and if HOMEBREW_PREFIX == /usr/local, then don't clean up the folder.