Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Casks without zap #88469

Open
vitorgalvao opened this issue Aug 31, 2020 · 139 comments
Open

Casks without zap #88469

vitorgalvao opened this issue Aug 31, 2020 · 139 comments
Labels
good first issue Issue which is easy to tackle for first-time contributors. help wanted

Comments

@vitorgalvao
Copy link
Member

vitorgalvao commented Aug 31, 2020 •
edited by khipp
Loading

This is a list of casks without a zap stanza. It is suitable for contributors of any experience level.

zaps do not require any special tool to figure out, but they can help speed up the process.

If you make a PR to add a cask from this list, please comment back with the name of the cask and a link to the PR. It helps with knowing when to rebuild the list.

Thank you for helping us with these.

Cask Downloads
wch-ch34x-usb-serial-driver 2,209
openzfs 1,629
cubicsdr 1,100
silicon-labs-vcp-driver 820
aquaskk 582
ftdi-vcp-driver 473
shadowsocksx 383
data-integration 349
j 345
taskwarrior-pomodoro 344
virtualgl 329
servo 328
factor 320
opensim 293
ncar-ncl 286
baiduinput 282
amd-power-gadget 266
fman 265
grafx 262
prolific-pl2303 242
handshaker 234
figtree 232
inssider 221
singularity 207
td-agent 206
asix-ax88179 197
itunes-producer 191
vidcutter 182
unity-ios-support-for-editor 171
google-analytics-opt-out 170
markdown-service-tools 154
secure-pipes 150
findergo 149
mjml 148
tla+-toolbox 142
password-gorilla 141
mini-vmac 140
cardinal 135
kugoumusic 130
unified-remote 129
airmedia 126
goldencheetah 115
ampps 114
quakespasm 106
blu-ray-player 103
caldigit-thunderbolt-charging 101
splayer 100
islide 96
blu-ray-player-pro 85
pokemon-showdown 85
doomsday-engine 80
tnefs-enough 80
ananas-analytics-desktop-edition 79
camed 76
flame 73
surge-synthesizer 72
wail 71
sauerbraten 67
kern 65
qt3dstudio 65
unlox 63
lightproxy 63
lockdown 62
hfsleuth 60
wavesurfer 60
runescape 59
pokerth 59
electric-sheep 59
opendnsupdater 57
roku-remote-tool 56
airpass 53
aimersoft-video-converter-ultimate 52
armory 51
ondesoft-audiobook-converter 49
leela 45
epoccam 44
ibored 42
itunes-volume-control 41
bitmessage 39
teeworlds 39
fitbit-os-simulator 39
hp-prime 39
tvrenamer 38
blheli-configurator 36
monity-helper 35
sleipnir 35
invesalius 35
jcryptool 34
m3unify 29
unity-windows-support-for-editor 27
ev3-classroom 25
nslogger 25
unity-android-support-for-editor 25
cinch 24
duckietv 24
dyn-updater 23
strawberry-wallpaper 23
isyncer 22
unity-webgl-support-for-editor 20
colorchecker-camera-calibration 18
redeclipse 16
sync-my-l2p 16
majsoul-plus 15
stationtv-link 12
jgrasp 12
tlv 9
@vitorgalvao vitorgalvao added the good first issue Issue which is easy to tackle for first-time contributors. label Aug 31, 2020
@vitorgalvao
Copy link
Member Author

@ran-dall Because you might be interested in the information: there’s almost four thousand casks without a zap (already excluding fonts). In this issue I’ve added five hundred for now (no particular order).

@vitorgalvao vitorgalvao mentioned this issue Aug 31, 2020
Closed
@Akylzhan
Copy link
Contributor

Akylzhan commented Sep 1, 2020

imgur #88545

Also, I believe that paintbrush already has zap stanza

@Akylzhan
Copy link
Contributor

Akylzhan commented Sep 1, 2020

Also, I can write here if some more casks already have zap stanza

@vitorgalvao
Copy link
Member Author

vitorgalvao commented Sep 1, 2020 •
edited
Loading

There was a bug in the script and it collected way more than it was supposed to. It was a coincidence that all the ones I checked didn’t have a zap. With the reduction, all casks now fit into this issue.

@ran-dall Update on that. They’re less than two and a half thousand.

@vitorgalvao vitorgalvao changed the title Incomplete list of casks without zap Casks without zap Sep 1, 2020
@ran-dall
Copy link
Contributor

ran-dall commented Sep 1, 2020

@vitorgalvao I'm working on this with the ML. I need a day or two. I'll have all the zaps inputted. Should I push to this PR?

@vitorgalvao
Copy link
Member Author

You mean the ML will be able to add all missing zaps?

@ran-dall
Copy link
Contributor

ran-dall commented Sep 1, 2020 •
edited
Loading

...yeah, and it should be able to maintain them too.

@vitorgalvao
Copy link
Member Author

That’s great. You can outright close the issue when that’s done, then.

@danielbayley
Copy link
Contributor

This is where #85820 and/or homebrew-createzap would come in handy…

@dmlemos
Copy link
Contributor

dmlemos commented Nov 10, 2020

Added zap for Freeplane on #92370

@redwoodtree
Copy link
Contributor

Added zap stanza for fldigi on 92764

@3719e04
Copy link
Contributor

3719e04 commented Nov 18, 2020

Added zap stanza for hstracker on #92899, for netnewswire on #92901, for zotero on #92906.

@3719e04
Copy link
Contributor

3719e04 commented Nov 20, 2020

@muneebmahmed added zap stanza for the cask cmake on #88809, but it was not cheked off the list.

@3719e04
Copy link
Contributor

3719e04 commented Nov 21, 2020

Added zap stanza for gpodder on #93240.

@fardage
Copy link
Contributor

fardage commented Dec 8, 2020

Added zap stanza for swish on #94909

@adithyasunil26
Copy link
Contributor

adithyasunil26 commented Dec 28, 2020 •
edited
Loading

Updated zap stanza for paintbrush on #97055 and added zap stanza for macspice on #97056

@vitorgalvao
Copy link
Member Author

Thank you all for the updates and the comments.

To clarify, in case you ever check the list and don’t see any boxes ticked, that’s because I semi-regularly regenerate the list (with only the ones missing).

@adithyasunil26
Copy link
Contributor

Added zap stanza for skybox on #97049 and snapndrag on #97050

@e-nomem
Copy link
Contributor

e-nomem commented Dec 30, 2020

Added zap stanza for pyfa in #97090

@adithyasunil26
Copy link
Contributor

Added zap stanza for texmaker on #97099 and hydrogen on #97098

@zhustec
Copy link
Contributor

zhustec commented Jan 3, 2021

Added zap stanza for tencent-lemon in #97181

@adithyasunil26
Copy link
Contributor

Added zap stanza for jenkins-menu in #97196 and updated zap stanza for amazon-music in #97129

@BrewTestBot BrewTestBot added the stale Issue which has not received any feedback for some time. label Jan 25, 2021
@Homebrew Homebrew deleted a comment from BrewTestBot Jan 25, 2021
@vitorgalvao vitorgalvao removed the stale Issue which has not received any feedback for some time. label Jan 25, 2021
@alexg0
Copy link
Contributor

alexg0 commented Feb 1, 2021

Added zap stanza for ringcentral-phone in #99161

@muneebmahmed muneebmahmed mentioned this issue Feb 21, 2021
Merged
9 tasks
@ondrejfuhrer ondrejfuhrer mentioned this issue Oct 9, 2022
Closed
3 tasks
@korverdev
Copy link
Contributor

Added zap to bean.

@aneitel
Copy link
Contributor

aneitel commented Jan 21, 2023

Added zap to

@vitorgalvao
Copy link
Member Author

vitorgalvao commented Jan 23, 2023 •
edited
Loading

List in top post updated. I usually do it without mentioning, but haven’t done so in a while so wanted to reinforce it’s still happening.

@aneitel
Copy link
Contributor

aneitel commented Jan 23, 2023

Added zap to

@senk
Copy link
Contributor

senk commented Feb 18, 2023

Added zap to

@Amorymeltzer
Copy link
Contributor

Added zap to:

@razvanazamfirei
Copy link
Member

Updated list sorted by number of downloads

@vitorgalvao
Copy link
Member Author

@razvanazamfirei Will you keep the list up to date? If so, I can just link to it in the top post, seems like a better approach.

We could also delete the script if you’re not using it.

@razvanazamfirei
Copy link
Member

@vitorgalvao, I wasn't aware of the script! I'll try modify it to include the download count so it's easy for people to prioritize.

@vitorgalvao
Copy link
Member Author

Note the script is to help update the top post, not necessarily to be used on its own. So if you have a different way of generating the list and are keeping it up-to-date (even once a month should suffice) we can just link to it above.

@razvanazamfirei razvanazamfirei mentioned this issue Apr 9, 2023
Merged
@razvanazamfirei
Copy link
Member

@vitorgalvao, my update to the script was merged and now the list includes (and is sorted by) the download count adds. Thanks for pointing me towards it.

@vitorgalvao vitorgalvao mentioned this issue Apr 10, 2023
Merged
@razvanazamfirei
Copy link
Member

Lots of zaps updated in:

List should be updated.

@philltran
Copy link
Contributor

philltran commented Apr 23, 2023 •
edited
Loading

Added PRs to add zaps to

@jazelly
Copy link
Contributor

jazelly commented Apr 26, 2023

No zap:

@jazelly
Copy link
Contributor

jazelly commented Apr 27, 2023

No zap:

@dannydorazio
Copy link
Contributor

Added zap to beamer in #146813

Finii added a commit to ryanoasis/nerd-fonts that referenced this issue May 13, 2023
@Finii
casks: Add zap stanza comment
fe9a2d7 
[why]
Casks without zap stanza are flagged; all casks should contain them.

The font casks do not really need zap.

[how]
What is the right way to say 'we considered zap, but do not need it'?

It seems that other people add a comment (the same comment).
For example here:
Homebrew/homebrew-cask#119090

And that seems rather widespread.

        git/homebrew-cask/Casks$ git grep '# No zap stanza required' | wc -l
        101

Include the same in our casks.

[note]
Homebrew/homebrew-cask#88469

Signed-off-by: Fini Jastrow <[email protected]>
@osalbahr
Copy link
Contributor

osalbahr commented Jul 1, 2023

Is there an easy way to sort this list by "most installed recently"?

@cdalvaro cdalvaro mentioned this issue Jul 29, 2023
Closed
4 tasks
@eriweb
Copy link
Contributor

eriweb commented Oct 3, 2023

Added zap to love in #156762.

@junwen-k
Copy link
Contributor

junwen-k commented Oct 24, 2023 •
edited
Loading

Added zap to

@0xdevalias
Copy link
Contributor

Curious, does the $(brew --repository homebrew/cask)/developer/bin/casks-without-zap script still work?

I tried running it and my clipboard seems to be blank at the end of it:

⇒ /usr/local/Homebrew/Library/Taps/homebrew/homebrew-cask/developer/bin/casks-without-zap run
Cloning into '/var/folders/j4/kxtq1cjs1l98xfqncjbsbx1c0000gn/T/d20231124-76676-z90h3p/homebrew-cask'...
remote: Enumerating objects: 4425, done.
remote: Counting objects: 100% (4425/4425), done.
remote: Compressing objects: 100% (4345/4345), done.
remote: Total 4425 (delta 100), reused 600 (delta 73), pack-reused 0
Receiving objects: 100% (4425/4425), 1.90 MiB | 6.67 MiB/s, done.
Resolving deltas: 100% (100/100), done.
Cloning into '/var/folders/j4/kxtq1cjs1l98xfqncjbsbx1c0000gn/T/d20231124-76676-z90h3p/homebrew-cask-versions'...
remote: Enumerating objects: 279, done.
remote: Counting objects: 100% (279/279), done.
remote: Compressing objects: 100% (263/263), done.
remote: Total 279 (delta 46), reused 101 (delta 13), pack-reused 0
Receiving objects: 100% (279/279), 153.81 KiB | 8.54 MiB/s, done.
Resolving deltas: 100% (46/46), done.
Copied lists to clipboard. Replace the information in the issue.

It might be useful to have a normal 'print to console' mode/flag, rather than using pbpaste to hijack the clipboard (as we can always just manually pipe the output to pbpaste):

https://github.com/Homebrew/homebrew-cask/blob/master/developer/bin/casks-without-zap#L111-L113

I see that the list of casks that need fixing hasn't been updated in quite a while; any chance of getting an update on this:

image

I haven't skimmed through all of the posts on this issue to see if there were any later updates about this, but I was wondering if this automation for adding/maintaining the zap clauses ever got completed?

I'm working on this with the ML. I need a day or two. I'll have all the zaps inputted. Should I push to this PR?

Originally posted by @ran-dall in #88469 (comment)

You mean the ML will be able to add all missing zaps?

Originally posted by @vitorgalvao in #88469 (comment)

...yeah, and it should be able to maintain them too.

Originally posted by @ran-dall in #88469 (comment)

That’s great. You can outright close the issue when that’s done, then.

Originally posted by @vitorgalvao in #88469 (comment)

LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 24, 2023
@Finii
casks: Add zap stanza comment
4ebddaa 
[why]
Casks without zap stanza are flagged; all casks should contain them.

The font casks do not really need zap.

[how]
What is the right way to say 'we considered zap, but do not need it'?

It seems that other people add a comment (the same comment).
For example here:
Homebrew/homebrew-cask#119090

And that seems rather widespread.

        git/homebrew-cask/Casks$ git grep '# No zap stanza required' | wc -l
        101

Include the same in our casks.

[note]
Homebrew/homebrew-cask#88469

Signed-off-by: Fini Jastrow <[email protected]>
@razvanazamfirei razvanazamfirei mentioned this issue Nov 24, 2023
Merged
@daeho-ro

This comment was marked as outdated.

Sign in to view
@daeho-ro
Copy link
Member

Added zaps to

@daeho-ro daeho-ro mentioned this issue Aug 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issue which is easy to tackle for first-time contributors. help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests