dev-cmd/livecheck: Skip autobumped formulae #18984
Conversation
- Skip formulae that are autobumped by BrewTestBot, to avoid useless effort spent by contributors who are checking for formulae to bump and then we close their PRs.
There was a problem hiding this comment.
As this is currently implemented, users don't have a way to disable this filtering behavior other than manually modifying this code. livecheck blocks for autobumped formulae/casks regularly break, so we need a way to be able to run these checks locally for debugging/fixing. A CLI option to also check autobumped packages (e.g., --autobump) would be a simple addition.
Beyond that, there may be something to be said for also offering an environment variable that would act like --autobump is always used (e.g., HOMEBREW_LIVECHECK_AUTOBUMP). My situation may be a bit rare (since I do a lot of livecheck block maintenance) but I almost never want to skip autobumped packages, so I would greatly prefer to not have to add a CLI option a lot of the time (and having to completely re-do long runs if I forget).
| autobump_core = File.read(autobump_core_path).lines.map(&:strip) | ||
| autobump_cask = File.read(autobump_cask_path).lines.map(&:strip) |
There was a problem hiding this comment.
| autobump_core = File.read(autobump_core_path).lines.map(&:strip) | |
| autobump_cask = File.read(autobump_cask_path).lines.map(&:strip) | |
| autobump_core = autobump_core_path.read.lines.map(&:strip) | |
| autobump_cask = autobump_cask_path.read.lines.map(&:strip) |
or .readlines may make sense
|
|
||
| sig { returns(Pathname) } | ||
| def autobump_core_path | ||
| @autobump_core_path ||= T.let(Tap.fetch("homebrew/core").path/".github/autobump.txt", T.nilable(Pathname)) |
There was a problem hiding this comment.
| @autobump_core_path ||= T.let(Tap.fetch("homebrew/core").path/".github/autobump.txt", T.nilable(Pathname)) | |
| @autobump_core_path ||= T.let(Tap.fetch("homebrew/core").path/".github/autobump.txt", Pathname) |
maybe?
|
OK, thanks @samford! I’ll add |
- This is useful for maintainers to check the full range of livecheck functionality.
- Livecheck blocks can exist in taps other than Core and Cask. - And packages can have the same name in multiple taps.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?