System messages are not hidden when showSystemMessages = false

[Anton-Svatko]

Describe the bug
The filterMessagesToShow method contains a logical error in the condition for filtering messages. Specifically, the condition:

shouldShowDeleted || (isSystemMessage && showSystemMessages)

This logic incorrectly allows all messages to be shown if shouldShowDeleted evaluates to true. Due to this bug, system messages are not hidden when showSystemMessages = false, even though they should be.

Proposed Solution
Replace the current condition:

shouldShowDeleted || (isSystemMessage && showSystemMessages)

With the corrected logic:

shouldShowDeleted && !(isSystemMessage && !showSystemMessages)

SDK version

• 6.8.0

To Reproduce

• Use showSystemMessages = false in MessagesViewModelFactory.
• Send system message in chat
• Open chat message is visible

Expected behavior

• Message must be hidden if showSystemMessages = false

Device:

• One plus 9r
• Android version: 14

Screenshots

[aleksandar-apostolov]

Hi @Anton-Svatko

Thanks for the report, we'll look into it.

Regards,
Alex