-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set of API improvements #29
Conversation
#30 should help |
This commits will fix build Action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking my sweet time with this.
I think there's a lot of really good stuff here - and thanks for contributing ! I'm not sold on all the changes yet unfortunately, so let's iterate a few times until we get it right!
Also CI seems to be failing |
It's strange. My fork pass tests successful I will try to resolve this |
I really have no idea why tests (I mean test - I guess this behavior undefined. But don't know why |
Ah, let me try to dive into the CI situation - that does seem super weird. It might take a week or so before I get around to it though. |
Turns out it's probably going to take longer - real life's getting in the way. You're not forgotten though. |
Maybe I can help? |
I mean absolutely do feel free to dive into the CI issue - there is a chance it's just a flaky test |
Can you try to run CI again? My branch passed tests three times in a row. If now problem isn't resolved... so, I will think a lot :) |
Still seems to be failing..! :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I have one spot that could do a little improving, but otherwise we're ready to merge this in! Thanks for sticking with me!
I rewrote tests. Yes, it's don't work again So, I don't know. Tomorrow I will add loggers to tests |
After reflecting on the amount of time I have to maintain this project, I don't think I will have time to handle PR's and stuff unfortunately. However, if you'd like to make a fork and publish that to nuget under a different name, I would be happy to link to it from this projects README |
Closes #24
Closes #25
Closes #26
Closes #27
Closes #28
Also it unintended resolve #22