Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when trying to remove unavailable source #405

Closed
jn64 opened this issue Jan 2, 2025 · 1 comment
Closed

Crash when trying to remove unavailable source #405

jn64 opened this issue Jan 2, 2025 · 1 comment

Comments

@jn64
Copy link
Contributor

jn64 commented Jan 2, 2025

Describe the bug
Font Manager segfaults when attempting to remove a source that no longer exists. The source is not removed.

To Reproduce
Steps to reproduce the behavior:

  1. Add a source in Font Manager e.g. /tmp/foo
  2. Delete the source (outside of Font Manager)
  3. Restart Font Manager or reload the Sources tab
  4. Select the source (now labelled "Source Unavailable") and click the minus button. Font Manager segfaults.

Expected behavior
Remove unavailable source safely.

System Information

  • OS: Fedora 41
  • Desktop Environment: Xfce
  • Font Manager version: 0.9.1 (font-manager-0:0.9.1.20240807-1.x86_64)
  • Font Manager installation method: COPR

Additional context
Workaround: recreate the source before removing it in Font Manager, or manually edit ~/.config/font-manager/Sources.xml.

@JerryCasiano
Copy link
Contributor

Thanks for catching and reporting this.

Not clear to me yet why a missing source is causing the path to become null but until I get a little more time the changes in master should eliminate this crash. The update should be available in the COPR repo shortly.

Feel free to re-open if you still have an issue and thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants