vgui.so must be located in build/cl_dll directory to produce a correct build on Linux

[FreeSlave]

I didn't manage to overcome this issue. And it seems like Valve didn't either as vgui.so is located in both linux and linux/release directories in their repo.

We have a workaround in github workflow by just copying vgui.so into the appropriate directory. But it's not applied automatically on the local build. Maybe some hack should be added to cmake script.

About the problem itself: vgui.so is problematic library as it does not have a commonly used lib prefix in its name nor the defined soname. So linker has a hard time finding it and adding the dependency with proper path. When going with -l:vgui.so approach, it writes the absolute path as a dependency for client.so which is unacceptable obviously.

If you want to experiment with it yourself, use this script to check out the dependencies of the produced client library:

objdump -p client.so | grep NEEDED | tr -s ' ' | cut -d ' ' -f 3

Running this on client.so from Steam Half-Life fetches this:

libstdc++.so.6
libdl.so.2
libpthread.so.0
vgui.so
libSDL2-2.0.so.0
libc.so.6

In case of our sdk it must result in

libdl.so.2
vgui.so
libstdc++.so.6
libm.so.6
libc.so.6

[a1batross]

It seems more like a bug of linker. If I'm using system toolchain, this doesn't happen anymore. If it uses steamrt toolchain, absolute path is written to the shared object.

It happens in both our HLSDK and vgui_support, compile set up using CMake and Waf.

Back in days when engine used cmake, I had a CMake macro that copied vgui.so before build starts, so it links normally.

[a1batross]

• Switching from ld.bfd to ld.gold doesn't help.
• Setting rpath doesn't help.

BUT:

• Switching from old ld 2.22 to ld-2.30 binary that present in SteamRT helps

[a1batross]

Solution from old engine https://github.com/FWGS/xash3d/blob/master/cmake/FWGSLib.cmake#L149-L173

Again, it seems irrelevant if we have binutils >2.30, as the post above shows. Probably some earlier versions could work too, if we want to target legacy.

[TailsFanLOL]

I copied it over yet it doesn't build. Am I stupid?

[alex@MiWiFi-R4AC-srv hlsdk-portable]$ cp vgui_support/vgui-dev/lib/vgui.so build/cl_dll
[alex@MiWiFi-R4AC-srv hlsdk-portable]$ env LANG=C cmake --build build
[  1%] Linking CXX shared library client_amd64.so
/usr/bin/ld: skipping incompatible /home/alex/ssd/Games/Counter-Strike 1.6/hlsdk-portable/vgui_support/vgui-dev/lib/vgui.so when searching for -l:vgui.so
/usr/bin/ld: skipping incompatible /home/alex/ssd/Games/Counter-Strike 1.6/hlsdk-portable/vgui_support/vgui-dev/lib/vgui.so when searching for -l:vgui.so
/usr/bin/ld: cannot find -l:vgui.so: No such file or directory
/usr/bin/ld: skipping incompatible /home/alex/ssd/Games/Counter-Strike 1.6/hlsdk-portable/vgui_support/vgui-dev/lib/vgui.so when searching for -l:vgui.so
/usr/bin/ld: skipping incompatible /home/alex/ssd/Games/Counter-Strike 1.6/hlsdk-portable/vgui_support/vgui-dev/lib/vgui.so when searching for -l:vgui.so
collect2: error: ld returned 1 exit status
make[2]: *** [cl_dll/CMakeFiles/client.dir/build.make:1393: cl_dll/client_amd64.so] Error 1
make[1]: *** [CMakeFiles/Makefile2:116: cl_dll/CMakeFiles/client.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Ignore MiWifi, I am not at home and this magical router changes my hostname somehow

[mittorn]

It is incompatible, you need amd64 vgui (and valve does not build it for amd64)