Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: collapsable pages #41

Open
ruigato opened this issue May 10, 2021 · 3 comments
Open

RFE: collapsable pages #41

ruigato opened this issue May 10, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ruigato
Copy link

ruigato commented May 10, 2021

would be really neat to be able to double click the header of each page to collapse / expand that page :)

@EnviralDesign
Copy link
Owner

Heyyo! Yes this is a big one and many have asked. very much the next task I will hit up when I have the bandwidth again (soonish I think)

I have some ideas recently for managing collapse/expand that I think would mesh into the existing framework decently.

Basically, any change or RFE that requires changing of the html structure generated causes big problems and requires complicated refactoring in other areas that I am trying to avoid if at all possible.

The complicated way (but possibly the "correct" way) to do this is to maybe integrate a wrapper div for each page group, and then through JS hide/show those divs and their content.

The slightly easier way is to flag certain page names, store them in extension list or table dat for visibility, and simply re generate the UI, omitting parameters that are children of pages flagged as collapsed. This is probably the way I'll go since it will not require any structural changes.

@EnviralDesign EnviralDesign self-assigned this May 19, 2021
@EnviralDesign EnviralDesign added the enhancement New feature or request label May 19, 2021
@EnviralDesign EnviralDesign added this to the 4.1.0 milestone May 19, 2021
@ruigato
Copy link
Author

ruigato commented May 20, 2021

glad to know its a common request! thank you for your insight, the first option seems more performant, mainly because of the redraw glitch that the regen of the second option will probably cause.

@drmbt
Copy link

drmbt commented Sep 28, 2021

I've built a version of this with page and par filtering, and collapses that is kind of clever. let me know if you've got some time coming up to rap about it, its a solid prototype but a bit hacky as i tried to integrate with the way you're doing things here... you'd likely have insight on a better way to implement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants