-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails on >24hr audiobooks & Reader Jumps Around #37
Comments
hm, Ill look into thisbut in the meantime I suppose you could try removing the activation of the Then you should just be left with a bunch of chapter wav files located in the Unless of course your issue comes before the creation of the final giant audiobook file |
the best is standardize the audio file with a max time, for ex 2 hours, and a consistent naming convention |
👍🏻 yeah for now I went the route of just commenting out create_m4b_from_chapters() and use m4b-tool to convert those which works great. |
@kkrausse v2.0 is out now, but I'm still working on it. If you have already some code for a PR don't hesitate to share it. |
it's a wav 32bit limited size. we need to add a function assembling the chunks once it reaches the limit which is 4GB. |
I changed the intermediate file type for the chapters to .mp3 @128kb/s in functions.py and haven't had any failures yet on the same files that previously failed due to the .wav file size limit. Biggest so far is >20h long. No clue if this could have other ramifications, but it's something that's worked for me so far. |
well, you tried it before any one of us... good to know! :) |
Was not me, but interested in the answer!
…On Thu, Jan 16, 2025, 7:06 AM ROBERT MCDOWELL ***@***.***> wrote:
@majormer <https://github.com/majormer> which function you changed to mp3?
—
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2XMTJ2URNOZVVTFYXGU3L2K6VD7AVCNFSM6AAAAABQSSAET6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJVGU4DQNJYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@Mr-Jiggledaddy which function you changed to mp3? combine_audio_sentences() or combine_audio_chapters()? |
I changed combine_audio_sentences (line 681): combined_audio.export(chapter_audio_file, format="mp3", bitrate="128k") Here's the file converted to .txt so it'll let me upload. I did have to change several other places where it checks for the file format (lines 555, 575, 833, 835), line 706 and 756 to from_mp3 instead of from_wav, and line 709 to format=mp3. I'm pretty sure that's everything I changed, but I did still have a failure on a 36h audiobook. Pydub has a PR open to implement the following change to audio_segment.py to allow >4gb file sizes, and that new version of audio_segment did work even on the 36h book. https://github.com/jiaaro/pydub/blob/4eb5818cff1fe65c1cbef40166c36c47df843287/pydub/audio_segment.py Would probably be more efficient to just replace the use of pydub for chapters and directly combine the chapters using ffmpeg, but I'm not that skilled and my 2 young kids demand the time I'd use to do it for now. Really awesome project though, hope it can become everything you guys want it to be, it's already getting some really good use for me. |
thanks for your encouragements... |
Seems like the failure at >24hr books is because final wav file gets too big.
Another (somewhat) related issue is that ebook reader randomly pauses and like jump backwards to random places.
Have you considered using m4b-tool instead of combining wav files & making the metadata yourself?
or maybe something with my files messes with the formatting.
edit: willing to work on this myself, but want to know if anyone has ideas first
The text was updated successfully, but these errors were encountered: