Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git_info.h debate #784

Open
alichraghi opened this issue Nov 15, 2024 · 1 comment
Open

git_info.h debate #784

alichraghi opened this issue Nov 15, 2024 · 1 comment
Assignees
@AnastaZIuk
Labels
bug Something isn't working CMake Build System

Comments

@alichraghi
Copy link
Member

git_info.h should probably not be a public header or at least should be grouped under nbl/ as it may conflict with other projects using Nabla.

Nabla/include/nbl/video/ILogicalDevice.h

Line 17 in de62785

#include "git_info.h"

See also #775 (comment)
@alichraghi alichraghi added bug Something isn't working CMake Build System labels Nov 15, 2024
@AnastaZIuk
Copy link
Member

AnastaZIuk commented Nov 19, 2024 •
edited
Loading

git_info.h should probably not be a public header

it should be in public headers, metadata should be accessible for projects linking Nabla (or gtml library directly)

nbl/ as it may conflict with other projects using Nabla

however we could have better include path for each meta header

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnastaZIuk AnastaZIuk

Labels
bug Something isn't working CMake Build System
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AnastaZIuk @alichraghi