Special characters used in the dogstatsd protocol are not escaped in metric name and namespace #740
Comments
|
Thanks for your contribution! This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community. If you would like this issue to remain open:
|
walerian777
pushed a commit
to walerian777/datadogpy
that referenced
this issue
Dec 12, 2022
According to the documentation https://docs.datadoghq.com/metrics/custom_metrics/#naming-custom-metrics metric names contain only ASCII alphanumerics, underscores, and periods, while other characters are converted to underscores. This commit ensures we replace all invalid characters with underscores for both namespaces and metric names. A similar thing has been already done for tags in DataDog#489 and DataDog#517, so I followed the example. It solves DataDog#740.
walerian777
pushed a commit
to walerian777/datadogpy
that referenced
this issue
Dec 12, 2022
According to the documentation https://docs.datadoghq.com/metrics/custom_metrics/#naming-custom-metrics metric names contain only ASCII alphanumerics, underscores, and periods, while other characters are converted to underscores. This commit ensures we replace all invalid characters with underscores for both namespaces and metric names. A similar thing has been already done for tags in DataDog#489 and DataDog#517, so I followed the example. It solves DataDog#740.
walerian777
pushed a commit
to walerian777/datadogpy
that referenced
this issue
Dec 12, 2022
According to the documentation https://docs.datadoghq.com/metrics/custom_metrics/#naming-custom-metrics metric names contain only ASCII alphanumerics, underscores, and periods, while other characters are converted to underscores. This commit ensures we replace all invalid characters with underscores for both namespaces and metric names. A similar thing has been already done for tags in DataDog#489 and DataDog#517, so I followed the example. It solves DataDog#740.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The metric serialization logic replaces special characters used in the dogstatsd protocol in tags, but not in metric namespace and name.
There are similar issues in other dogstatsd client libraries:
The text was updated successfully, but these errors were encountered: