Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search facets openByDefault by configuration #9404

Open
floriangantner opened this issue Mar 8, 2024 · 0 comments · May be fixed by #10169 or DSpace/dspace-angular#3785
Open

search facets openByDefault by configuration #9404

floriangantner opened this issue Mar 8, 2024 · 0 comments · May be fixed by #10169 or DSpace/dspace-angular#3785
Assignees
Labels
component: Discovery Related to Discovery search or browse system help wanted Needs a volunteer to claim to move forward new feature

Comments

@floriangantner
Copy link
Contributor

floriangantner commented Mar 8, 2024

Is your feature request related to a problem? Please describe.
The sidebar facets are initially not openByDefault.
Screenshot 2024-03-08 at 12-55-36 DSpace Repository Search

There is some Configuration on the filterfacet, e.g. on author which is set to true
<property name="isOpenByDefault" value="true"/>

<property name="isOpenByDefault" value="true"/>

Describe the solution you'd like
We would like the sidebar facets to be opened initially by the openByDefault parameter. This is currently only exposed to the search filter endpoint, but not on the request to the single facet.

Screenshot 2024-03-08 at 12-42-07 DSpace Repository Search

Describe alternatives or workarounds you've considered

  • use the opened state from the filters endpoint. This endpoint exposes the openByDefault information in some previous request but it seems to be unused or overwritten by the result of the facet endpoint
  • move the isOpenByDefault property from DiscoverySearchFilter to DiscoverySearchfilterFacet and adjust the usages (a lot (>100) in discovery.xml - not a real alternative)

Additional context

  • I've search the issue board but could not find any matching issue - if it is some duplicate, Pardon
  • I'm currently unsure at which point any filter will be opened on DSpace by the setting. Maybe it is some legacy from dspace5? It is also not mentioned in the Docs https://wiki.lyrasis.org/display/DSDOC7x/Discovery#Discovery-Searchfilters&sidebarfacetsCustomization but appears in the example configuration
  • this feature will impact the appearance of most DSpace instances which align to the default discovery configuration beans

We can provide some PR adressing this:
Shortly summarized:

@floriangantner floriangantner added needs triage New issue needs triage and/or scheduling new feature labels Mar 8, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Mar 8, 2024
@floriangantner floriangantner changed the title open search facets initially by configuration search facets openByDefault by configuration Mar 8, 2024
floriangantner added a commit to uniba-ub/dspace-angular that referenced this issue Mar 8, 2024
floriangantner added a commit to uniba-ub/Rest7Contract that referenced this issue Mar 8, 2024
@tdonohue tdonohue added the component: Discovery Related to Discovery search or browse system label Mar 8, 2024
@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward and removed needs triage New issue needs triage and/or scheduling labels May 1, 2024
@tdonohue tdonohue moved this from 🆕 Triage to 🙋 Needs Help / Unscheduled in DSpace Backlog May 1, 2024
floriangantner added a commit to uniba-ub/dspace-angular that referenced this issue Dec 27, 2024
floriangantner added a commit to uniba-ub/dspace-angular that referenced this issue Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Discovery Related to Discovery search or browse system help wanted Needs a volunteer to claim to move forward new feature
Projects
Status: 🙋 Needs Help / Unscheduled
2 participants