-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search facets openByDefault by configuration #9404
Open
floriangantner opened this issue
Mar 8, 2024
· 0 comments
· May be fixed by #10169 or DSpace/dspace-angular#3785
Open
search facets openByDefault by configuration #9404
floriangantner opened this issue
Mar 8, 2024
· 0 comments
· May be fixed by #10169 or DSpace/dspace-angular#3785
Labels
component: Discovery
Related to Discovery search or browse system
help wanted
Needs a volunteer to claim to move forward
new feature
Comments
floriangantner
added
needs triage
New issue needs triage and/or scheduling
new feature
labels
Mar 8, 2024
floriangantner
changed the title
open search facets initially by configuration
search facets openByDefault by configuration
Mar 8, 2024
floriangantner
added a commit
to uniba-ub/DSpace
that referenced
this issue
Mar 8, 2024
floriangantner
added a commit
to uniba-ub/dspace-angular
that referenced
this issue
Mar 8, 2024
floriangantner
added a commit
to uniba-ub/Rest7Contract
that referenced
this issue
Mar 8, 2024
tdonohue
added
the
component: Discovery
Related to Discovery search or browse system
label
Mar 8, 2024
floriangantner
added a commit
to uniba-ub/DSpace
that referenced
this issue
Mar 11, 2024
tdonohue
added
help wanted
Needs a volunteer to claim to move forward
and removed
needs triage
New issue needs triage and/or scheduling
labels
May 1, 2024
floriangantner
added a commit
to uniba-ub/DSpace
that referenced
this issue
Dec 27, 2024
floriangantner
added a commit
to uniba-ub/DSpace
that referenced
this issue
Dec 27, 2024
floriangantner
added a commit
to uniba-ub/dspace-angular
that referenced
this issue
Dec 27, 2024
floriangantner
added a commit
to uniba-ub/DSpace
that referenced
this issue
Dec 27, 2024
10 tasks
floriangantner
added a commit
to uniba-ub/dspace-angular
that referenced
this issue
Dec 27, 2024
This was referenced Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: Discovery
Related to Discovery search or browse system
help wanted
Needs a volunteer to claim to move forward
new feature
Is your feature request related to a problem? Please describe.
The sidebar facets are initially not
openByDefault
.There is some Configuration on the filterfacet, e.g. on author which is set to true
<property name="isOpenByDefault" value="true"/>
DSpace/dspace/config/spring/api/discovery.xml
Line 2567 in eee0bfd
Describe the solution you'd like
We would like the sidebar facets to be opened initially by the
openByDefault
parameter. This is currently only exposed to the search filter endpoint, but not on the request to the single facet.Describe alternatives or workarounds you've considered
openByDefault
information in some previous request but it seems to be unused or overwritten by the result of the facet endpointDiscoverySearchFilter
toDiscoverySearchfilterFacet
and adjust the usages (a lot (>100) in discovery.xml - not a real alternative)Additional context
We can provide some PR adressing this:
Shortly summarized:
https://github.com/DSpace/RestContract/blob/02764cbedc66706ab1747edfc8656039e99e0172/search-endpoint.md?plain=1#L421
SearchFacetEntryRest
representation. This property has to be added in theDiscoverFacetResultsConverter
andDiscoverFacetConfigurationConverter
., because there seems to be some problem to expose rest objects starting with
is
(= boolean getter)The text was updated successfully, but these errors were encountered: