-
Notifications
You must be signed in to change notification settings - Fork 10
Split RouteConfig from app.component #127
Comments
This may be a good idea for app.component, but then would it be done for the child routes as well? If we seperate app.component routes into a seperate route file then we should do the same for the child component routes. For this I think it makes less sense and would require additional folder/file structure to accommodate. |
The way in which we have used child routes now is okay I think. The item component is quite small (surely compared to app.component), and splitting it off for just two routes might be a overkill. To me, it seems like app.component is already quite a large file. We are also going in against some style guidelines from angular2 about how to structure the components as it is.
It is quite a big template, and we are adding a routeconfig and typescript in the same file. Keeping in mind that our RouteConfig is likely going to grow some more, it might be best to at least split this one. |
Sounds good to me. We still have the issue of extracting templates into html files. |
We do indeed @wwelling . I'm not sure what the idea is going forward, keep it as we have it now, or split them in component.ts and component.html files? |
I came across this SO post and I believe that it makes sense to put our RouteConfig in a separate file, rather than also adding them to app.component
The text was updated successfully, but these errors were encountered: