Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about introducing new DLL dependencies #605

Open
SadPencil opened this issue Jan 2, 2025 · 0 comments
Open

Add documentation about introducing new DLL dependencies #605

SadPencil opened this issue Jan 2, 2025 · 0 comments

Comments

@SadPencil
Copy link
Member

SadPencil commented Jan 2, 2025

several years ago, the client prioritize DLL files in Binaries folder than in Binaries\Windows folder
and then during .NET 6 or .NET 8 migration, I reversed the priority so the client can tolerate the old ClientCore.dll file in Binaries folder
at the cost, if an old DLL exists in Windows/XNA/OpenGL folder, it will have a higher priority
This requires us when introducing a new dependency,
if a DLL file should be shared (the same) among Windows/XNA/OpenGL builds, it should be added in the common list in the very begining
otherwise, once we have release the client for even once, it would require the modder manually deleting it in the updater file

A documentation should explicitly write this requirements. See also Get-CommonAssemblyList.ps1 file. One should click "BuildAres.bat" file first, and then execute this PowerShell script to update the CommonAssemblies.txt and CommonAssembliesNetFx.txt files. Note that currently ClientUpdater.dll is an exception. ClientUpdater.dll should stay in these two txt files even if the script think it is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant