Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SolutionTolerance for SA tolerance #130

Closed
Tracked by #135
charleskawczynski opened this issue Sep 15, 2022 · 1 comment
Closed
Tracked by #135

Use SolutionTolerance for SA tolerance #130

charleskawczynski opened this issue Sep 15, 2022 · 1 comment

Comments

@charleskawczynski
Copy link
Member

Deriving a meaningful ResidualTolerance for a variety of inputs is bit difficult, a simpler solution is to change to using SolutionTolerance, since the magnitude and criteria is clear
This was referenced Sep 22, 2022
Closed
Closed
@charleskawczynski charleskawczynski mentioned this issue Oct 4, 2022
Merged
bors bot added a commit that referenced this issue Oct 5, 2022
@bors @charleskawczynski
Merge #139
45a4c01 
139: Use SolutionTolerance instead of ResidualTolerance r=charleskawczynski a=charleskawczynski

This PR replaces the `RootSolvers.ResidualTolerance` with `RootSolvers.SolutionTolerance`. Closes #135, #134, #130.

Co-authored-by: Charles Kawczynski <[email protected]>
bors bot added a commit that referenced this issue Oct 5, 2022
@bors @charleskawczynski
Merge #139
d7d03c0 
139: Use SolutionTolerance instead of ResidualTolerance r=charleskawczynski a=charleskawczynski

This PR replaces the `RootSolvers.ResidualTolerance` with `RootSolvers.SolutionTolerance`. Closes #135, #134, #130.

Co-authored-by: Charles Kawczynski <[email protected]>
@charleskawczynski
Copy link
Member Author

Closed by #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change tolerance from energy to temperature CliMA/Thermodynamics.jl
1 participant
@charleskawczynski