Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Do we need stop -force|-f? #795

Open
yaazkal opened this issue Jan 6, 2025 · 1 comment
Open

[ENHANCEMENT] Do we need stop -force|-f? #795

yaazkal opened this issue Jan 6, 2025 · 1 comment
Labels
enhancement New feature or request experimental Experimental features

Comments

@yaazkal
Copy link
Collaborator

yaazkal commented Jan 6, 2025

Is your feature request related to a problem? Please describe.
This is a follow up of PR #749

Describe the solution you'd like
As a fail unmount could happen for multiple reasons and can have side effects for the user, let's think if:

  1. Also use the -f option of the umount system command if it's safe to do it in the stop command. Will this mean a new -f option to the stop command?

  2. And what about to also giving an error_exit in the stop command if the unmount was not possible for any given reason? Also, will this mean a new -f option to the stop command?

  3. destroy -f will use stop -f if gets implemented

cc @tschettervictor @bmac2 @cedwards

@yaazkal yaazkal added enhancement New feature or request experimental Experimental features labels Jan 6, 2025
@yaazkal yaazkal changed the title [ENHANCEMENT] Do we need stop -force|-f ? [ENHANCEMENT] Do we need stop -force|-f? Jan 6, 2025
@tschettervictor
Copy link
Collaborator

@yaazkal I was wrong earlier. Using the -f option in destroy actually does a "zfs -rf destroy"

This means it attempts to force unmount the dataset when destroying it. But as we have seen this sometimes doesn't work, and can lead to data loss.

The only way in my experience past a failed unmount is a reboot of the server.

So I don't think having the -f option in stop.sh will help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request experimental Experimental features
Projects
None yet
Development

No branches or pull requests

2 participants