Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] create: Change "interface" to "ip4.addr = if|ip" #788

Open
tschettervictor opened this issue Jan 4, 2025 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@tschettervictor
Copy link
Collaborator

tschettervictor commented Jan 4, 2025

Since I've started working on PR #783, I've noticed a few minor things that could be tweaked.

  1. Classic jails get created in this following format
  interface = bastille0;
  ip4.addr = 10.0.0.1;

This makes it slightly difficult to deal with adding and removing interfaces from the jail.conf file.

I've currently implemented the following structure when creating jails
ip4.addr = bastille0|10.0.0.1

This makes it really easy to add multiple IP/interface pairs like the following example.

  ip4.addr = bastille0|10.0.0.1
  ip4.addr += bastille0|10.0.0.2
  ip4.addr += bastille0|10.0.0.3
  ip4.addr += bridge0|10.0.1.9

I will suggest editing create.sh (which I have done easily in my version) to just create classic jails in that way.

@tschettervictor tschettervictor added the enhancement New feature or request label Jan 4, 2025
@tschettervictor tschettervictor changed the title [ENHANCEMENT] [ENHANCEMENT] create: Change "interface" to "ip4.addr = if|ip" Jan 4, 2025
@bmac2
Copy link
Collaborator

bmac2 commented Jan 4, 2025

I am ok with the change.

@yaazkal your thoughts?

@tschettervictor
Copy link
Collaborator Author

@JRGTH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants