-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Allow users to console into a container by using the $JID # in addition to the hostname. #701
Comments
Thanks for the suggestion, let me say that a name like That said, Let's see what other people think. |
Lol yes I agree that wildly long host names are the users own fault.
However that IS what the user asked you to do. Trying to console into a
long or even moderate hostbame sucks. $JID’s are much much shorter. And
make trying to console into jails much faster and easier. I’m not sure why
there hasn’t been more comment on this. This is a clear win for usability.
Which is the sole reason I brought this up. It’s just a usability
enhancement. And if we don’t do this now I’m almost certain in the future
this is going to be an issue with users imo.
Chris
…On Sat, Nov 23, 2024 at 10:36 PM Juan David Hurtado G < ***@***.***> wrote:
No comments in a long time. I don't see any priority for this, what do you
think @bmac2 <https://github.com/bmac2> @cedwards
<https://github.com/cedwards> ?
—
Reply to this email directly, view it on GitHub
<#701 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD66VIRH4IE7JXSHJYFL54L2CFJVBAVCNFSM6AAAAABIQDYD3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJVHAYDAMBQGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sure, thanks for commenting back. This issue will remain open to not lost track of it, just not a priority at the moment. We will need to agree if the proposed Anyway PRs are welcome. Regards. |
No worries! Thanks for reminding me about this and keeping it active!
Chris
…On Sun, Nov 24, 2024 at 9:33 AM Juan David Hurtado G < ***@***.***> wrote:
Sure, thanks for commenting back.
This issue will remain open to not lost track of it, just not a priority
at the moment. We will need to agree if the proposed -j option is the way
to go.
Anyway PRs are welcome.
Regards.
—
Reply to this email directly, view it on GitHub
<#701 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD66VIVDPY7EYLU2E5RRBGT2CHWWHAVCNFSM6AAAAABIQDYD3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJWGA3DMMJUHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I think it would be practical to have an “autocomplete” for jail names. Iocage has this. You could do “bastille console really” and I enter a jail that starts with that word, as long as that is the only one. |
Added PR #758 |
Thanks @tschettervictor While it does not cover what @X86BSD is asking, I guess that would be a nice feature. It will need testing. I'll left my comments in the PR next weekend. I'll keep this issue open to not lose track of it. |
I like the -j option. autocomplete is cool but jail number is the suggestion and I think we should do it. |
I'm with @yaazkal here, "I don't think it should necesary has to delete the use of the command with the jail name" Rather than deleting an option, it just can be enhanced to also look for JID in the same command without making things complicated, and this is a very simple task to implement regardless. Regards! |
Cool. I think we should expand it to allow for use with other commands also. The "set_target" function I've recently implemented would allow for this. I'll implement it... |
My opinion is that you don't need a switch, but if you specify a number as the TARGET, then the function will associate the number with the proper jail name and set it as such. |
I have this implemented now. Just waiting on some PRs to be accepted before I open this one.
|
This is exactly what I was suggesting. Just a simple way to console into a
jail using a much shorter numeric $JID vs a horrendous long host name. This
is great! I can’t thank you enough for this. Well done! I’m positive this
will have a large impact on usability for users. Hopefully it wasn’t too
much heavy lifting to accomplish. The user community thanks you!
…-Chris
On Sun, Jan 5, 2025 at 12:30 PM tschettervictor ***@***.***> wrote:
I have this implemented now. Just waiting on some PRs to be accepted
before I open this one.
***@***.***:~ # bastille console 20
[jail1]:
***@***.***:~ #
—
Reply to this email directly, view it on GitHub
<#701 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD66VITEQ6UEIADOZ4B2CQT2JF23ZAVCNFSM6AAAAABIQDYD3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRG4YTEOBTGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
|
autocomplete also working |
Is your feature request related to a problem? Please describe.
This was briefly discussed in #193 along with a patch (at the time) by johanhen.
This is another usability issue, not a bug. When using bastille for more than a small number of containers, using the hostname to console into the containers becomes... tedious. No one wants to type: "bastille console reallyreallylonghostnamethattakestoolongtotypeandiserrorprone". When it would be MUCH quicker and simpler and remove that pain point to simply use the JID #. "bastille console 1" is clearly easier to do than having to type in the reallyreallylonghostname.
Describe the solution you'd like
What I would like to see is a small modification so that users can simply type in the JID # when console'ing into a container. I'm not proposing changing the current way of typing in the hostname, I am simply suggesting to allow the user to enter either the hostname OR the JID # to console into a container. Ex. "bastille console 1". I am actually kind of surprised this has not been brought up before. Using hostname's only imo becomes tedious pretty quickly with more than a handful of jails. This is not a high priority of course, just something I think is a pain point I would like to see removed.
The text was updated successfully, but these errors were encountered: