Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fabric E2E Sample] Add AzDO Variable Group creation to deployment #991

Merged
merged 9 commits into from
Jan 2, 2025
Merged

[Fabric E2E Sample] Add AzDO Variable Group creation to deployment #991

merged 9 commits into from
Jan 2, 2025

Conversation

devlace
Copy link
Contributor

@devlace devlace commented Dec 24, 2024 •
edited by promisinganuj
Loading

Type of PR

  • Documentation changes
  • Code changes

Purpose

  • This uses the Azure DevOps Terraform provider to create a new Azure DevOps Variable Group as part of the larger deployment script.

Does this introduce a breaking change? If yes, details on what can break

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

  • ...

Issues Closed or Referenced

@devlace devlace changed the base branch from main to feat/e2e-fabric-dataops-sample-v0-2 December 24, 2024 04:16
@devlace devlace added the e2e: fabric Related with E2E Fabric Sample label Dec 24, 2024
@promisinganuj promisinganuj self-requested a review December 30, 2024 23:07
@promisinganuj
Copy link
Contributor

@devlace , please update the deployed resources details in the following sections of the readme:

https://github.com/Azure-Samples/modern-data-warehouse-dataops/tree/feat/e2e-fabric-dataops-sample-v0-2/e2e_samples/fabric_dataops_sample#verifying-the-infrastructure-deployment

https://github.com/Azure-Samples/modern-data-warehouse-dataops/tree/feat/e2e-fabric-dataops-sample-v0-2/e2e_samples/fabric_dataops_sample#deployed-resources

@promisinganuj
Copy link
Contributor

Tested, looks good. The variable group and the variable is getting created successfully.

image

image

Also, the variable group is getting destroyed when running the cleanup script.

promisinganuj
promisinganuj approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@promisinganuj promisinganuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the details of deployed resources in README.md. The code changes looks good.

@promisinganuj promisinganuj changed the title Fabric E2E: Add AzDO Variable Group creation to deployment [Fabric E2E Sample] Add AzDO Variable Group creation to deployment Dec 31, 2024
naga-nandyala
naga-nandyala approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@naga-nandyala naga-nandyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did a fresh deployment and cleanup. Everything works as expected.

@promisinganuj promisinganuj merged commit 32dce2e into feat/e2e-fabric-dataops-sample-v0-2 Jan 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naga-nandyala naga-nandyala naga-nandyala approved these changes

@promisinganuj promisinganuj promisinganuj approved these changes

Assignees

@devlace devlace

Labels
e2e: fabric Related with E2E Fabric Sample
Projects
None yet
Milestone
E2E - parking_sensor_fabric - V1
Development

Successfully merging this pull request may close these issues.

Create Variable Groups
3 participants
@devlace @promisinganuj @naga-nandyala