Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Preload "Include with your purchase" items in the state. #98528

Open
StevenDufresne opened this issue Jan 17, 2025 · 1 comment · May be fixed by #98578
Open

Feature Request: Preload "Include with your purchase" items in the state. #98528

StevenDufresne opened this issue Jan 17, 2025 · 1 comment · May be fixed by #98578
Assignees
Labels
[Feature Group] WPCOM Store & Purchases All things billing on WordPress.com. This includes the backend store, plans, and billing management. [Feature] Shopping Cart Anything related to the shopping cart in Calypso, like adding items to the cart, the mini-cart, etc. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] In Progress [Type] Feature Request Feature requests

Comments

@StevenDufresne
Copy link
Contributor

What

Include with your purchase is loading but my products are not.

As a user, it's unclear why I would be waiting to learn what's included in this purchase when all my products are listed on the left.

Screenshot

Image

Why

This loading state is not mission-critical to the cart but is particularly distracting.

How

No response

@StevenDufresne StevenDufresne added [Feature Group] WPCOM Store & Purchases All things billing on WordPress.com. This includes the backend store, plans, and billing management. [Feature] Shopping Cart Anything related to the shopping cart in Calypso, like adding items to the cart, the mini-cart, etc. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Feature Request Feature requests labels Jan 17, 2025
@StevenDufresne StevenDufresne changed the title Feature Request: Feature Request: Preload "Include with your purchase" items in the state. Jan 17, 2025
@StevenDufresne
Copy link
Contributor Author

This is happening because when usePrefillCheckoutContactForm finds cached contact details, it updates the state via setStepCompleteStatus and causes the form to change from ready to validating which is how the WPCheckoutOrderSummary determines whether the cart is loading.

Ideally, we can change it so it only loads when products change. Since the total also relies on the same isCartUpdating logic and is affected by contact information (tax), it's probably safer to make the change for the CheckoutSummaryFeaturedList only. I'll look more closely at the feature list to make sure it doesn't rely on contact information as well before.

Noting, I opened a separate ticket for the contact details section loading. I'm hoping it may be possible to prefill contact information before page load to avoid this loading stage entirely but either way this should probably be separated out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] WPCOM Store & Purchases All things billing on WordPress.com. This includes the backend store, plans, and billing management. [Feature] Shopping Cart Anything related to the shopping cart in Calypso, like adding items to the cart, the mini-cart, etc. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] In Progress [Type] Feature Request Feature requests
Projects
Development

Successfully merging a pull request may close this issue.

1 participant