Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolbar icons still blue even though #disable-thorium-icons flag is enabled #296

Open
mohab001 opened this issue Oct 30, 2024 · 5 comments

Comments

@mohab001
Copy link

System Details

  • OS: [Windows 10]
  • Thorium Version [128.0.6613.189]

Problem
Home button icon and extensions icon are still blue even though #disable-thorium-icons flag is enabled (it only changes reload icon)

Screenshots
image

@gz83
Copy link
Collaborator

gz83 commented Oct 30, 2024

This is intentional

@mohab001
Copy link
Author

It would be nice to have the option to make toolbars icons color decided by themes, or at least add the option to revert them back to the default gray color, cause it looks really ugly with some themes.
Also the flag is kinda pointless if it changes only one icon.

@Alex313031
Copy link
Owner

@gz83 @mohab001 Nope, this IS a bug. The home button is using the incorrect .icon file. I will fix.

@Alex313031
Copy link
Owner

@gz83 In fact, next release I have to rebase ALL the .icon files, as they changed the default line width and font size > https://source.chromium.org/chromium/chromium/src/+/f824ddc5635f14e9fe879df062d8fbd66251f312

@mezhgano
Copy link

mezhgano commented Nov 9, 2024

I'm on latest release (M128.0.6613.189) with #disable-thorium-icons flag enabled.
Player and tab mute icons is violet:

Screenshot 2024-11-09 14-20-50_-YouTube-_Thor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants