-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment based settings #71
Comments
Hi @pgraham3, I've been wanting something similar. With today's announcement of Sandbox mode it becomes even more useful. I'd be happy to work on a PR for this. I was thinking of an approach like this: https://wpmailsmtp.com/docs/how-to-secure-smtp-settings-by-using-constants/ Basically check for the existence of constants in A downside to this approach is It wouldn't use the WordPress environment setting. If that was to be used then you would need to store two sets of settings, one for Sandbox and one for Production. I'd be happy to look at a PR taking that route too. Both of those things could be implemented as well... Check for sandbox and production constants in |
@tflight I like this idea/approach as well! Thanks for the offer to work on a PR for it. Happy to review it when it is ready. |
Great, I'll get a PR soon. It looks like this repo is a version behind what is in the Plugins directory, so maybe you can get this repo up to date first? |
All set! Should have parity with the WordPress repo's trunk now. |
Been looking for a solution like this for a LONG time. We are a web hosting agency and having this functionality would allow us to ditch SendGrid and move to Postmark for our outbound transactional notifications from WordPress. It would be great if there was a way to have an environmental var that could completely hide the plugin. Customers do dumb things. :) Glad to help test this out! |
Potentially related to #69
The text was updated successfully, but these errors were encountered: