Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : PDF Generation Issues #114

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix : PDF Generation Issues #114

merged 1 commit into from
Jan 9, 2025

Conversation

Naman-B-Parlecha
Copy link
Contributor

This PR fixes the following as mention in ISSUE #112

  1. When generating MCQ-type questions, some questions are showing as undefined.
  2. Occasionally, there is an overflow question where the question is excessively long and breaks the formatting.
  3. There is no cap of 5 questions per page for better readability, causing cluttered PDFs.

pdf before this pr : generated_questions.pdf

pdf after this pr : generated_questions (5).pdf

Closes #112

@Naman-B-Parlecha
Copy link
Contributor Author

Naman-B-Parlecha commented Jan 5, 2025 •
edited
Loading

@Roaster05 @Aditya062003 awaiting your review!!

@Roaster05
Copy link
Contributor

@Aditya062003 this looks good to me , we can merge this

@Roaster05 Roaster05 merged commit 34a92a9 into AOSSIE-Org:main Jan 9, 2025
Aditya062003
Aditya062003 reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@Aditya062003 Aditya062003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let us know after fixing the requested changes.

eduaid_web/src/pages/Output.jsx Show resolved Hide resolved
eduaid_web/src/pages/Output.jsx Show resolved Hide resolved
Aditya062003 added a commit that referenced this pull request Jan 9, 2025
@Aditya062003
Revert "Fixing PDF generation (#114)"
678d490 
This reverts commit 34a92a9.
@Aditya062003 Aditya062003 mentioned this pull request Jan 9, 2025
Merged
@Naman-B-Parlecha Naman-B-Parlecha mentioned this pull request Jan 9, 2025
Open
moodyadi2006 pushed a commit to moodyadi2006/EduAid that referenced this pull request Jan 24, 2025
@Naman-B-Parlecha
Fixing PDF generation (AOSSIE-Org#114)
79b7a00
moodyadi2006 pushed a commit to moodyadi2006/EduAid that referenced this pull request Jan 24, 2025
@Aditya062003
Revert "Fixing PDF generation (AOSSIE-Org#114)"
85e8e28 
This reverts commit 34a92a9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aditya062003 Aditya062003 Aditya062003 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: PDF Generation Issues
3 participants
@Naman-B-Parlecha @Roaster05 @Aditya062003