You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This would be a great feature and I have opened a issue about it for a while now #163.
However thinking about this I have realized that because we are using docker-compose file-format for parametrize out containers, we would have to implement the same functionality again.
This brings me to the core of the discussion - it might be a good idea to scrap the Python code responsible for building the Docker containers and absorb all of the functionality into the Golang code.
The benefits are:
it is a really good feature to have
potentially less code to maintain
one whole programming language less in repo
one tool less (daggerci would be absorbed into firmware-action)
a lot of litter files would be removed from the repository such are .pylintrc, requirements.txt, and so on
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
This would be a great feature and I have opened a issue about it for a while now #163.
However thinking about this I have realized that because we are using
docker-compose
file-format for parametrize out containers, we would have to implement the same functionality again.This brings me to the core of the discussion - it might be a good idea to scrap the Python code responsible for building the Docker containers and absorb all of the functionality into the Golang code.
The benefits are:
daggerci
would be absorbed intofirmware-action
).pylintrc
,requirements.txt
, and so onDrawbacks are:
Beta Was this translation helpful? Give feedback.
All reactions