Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond to https://github.com/jupyterhub/repo2docker/pull/1376 #5183

Closed
2 tasks done
yuvipanda opened this issue Nov 23, 2024 · 1 comment
Closed
2 tasks done

Respond to https://github.com/jupyterhub/repo2docker/pull/1376 #5183

yuvipanda opened this issue Nov 23, 2024 · 1 comment
Assignees

Comments

@yuvipanda
Copy link
Member

yuvipanda commented Nov 23, 2024

jupyterhub/repo2docker#1376 has been sitting for a month, and is a brand new contribution from someone who is new to the Jupyter ecosystem but seems to be a big contributor to the Julia ecosystem

Suggested Steps

These are purely suggested steps, and need not be followed. Our goal is to see if this PR improves the project, and

  1. Setup a local dev environment of repo2docker
  2. Validate that the warning the contributor reported is present without this PR
  3. Pull julia_project.py: fix Pkg REPL api warning jupyterhub/repo2docker#1376 and test to see if that fixes the issue
  4. ??? We have to figure it out from here collectively :) Use your best judgement and ask questions!

Definition of done

@GeorgianaElena
Copy link
Member

@agoose77 and I paired on this task and merged the PR today jupyterhub/repo2docker#1376 🎉 🚀

We time-boxed our investigation to 1h and during this time we also managed to do some extensive digging around the Julia command in the PR and we ended up opening a follow-up up task about the possibility of further simplifying it jupyterhub/repo2docker#1383.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants